tree 129f93affe13fd89e385f905b4f1de5f486d4f98
parent b83dc3d2ef5ffa882aed926ee4d6a82bd94024f0
author Olivier Houchard <ohouchard@haproxy.com> 1492594450 +0200
committer Willy Tarreau <w@1wt.eu> 1492596874 +0200
encoding latin1

BUG/MAJOR: Use -fwrapv.

Haproxy relies on signed integer wraparound on overflow, however this is
really an undefined behavior, so the C compiler is allowed to do whatever
it wants, and clang does exactly that, and that causes problems when the
timer goes from <= INT_MAX to > INT_MAX, and explains the various hangs
reported on FreeBSD every 49.7 days. To make sure we get the intended
behavior, use -fwrapv for now. A proper fix is to switch everything to
unsigned, and it will happen later, but this is simpler, and more likely to
be backported to the stable branches.
Many thanks to David King, Mark S, Dave Cottlehuber, Slawa Olhovchenkov,
Piotr Pawel Stefaniak, and any other I may have forgotten for reporting that
and investigating.