MINOR: chunk: make chunk_initstr() take a const string
chunk_initstr() prepares a read-only chunk from a string of
fixed length. Thus it must be prepared to accept a read-only
string on the input, otherwise the caller has to force-cast
some const char* and that's not a good idea.
diff --git a/include/common/chunk.h b/include/common/chunk.h
index 35bf219..851c7a6 100644
--- a/include/common/chunk.h
+++ b/include/common/chunk.h
@@ -77,9 +77,10 @@
return 1;
}
-static inline void chunk_initstr(struct chunk *chk, char *str)
+/* this is only for temporary manipulation, the chunk is read-only */
+static inline void chunk_initstr(struct chunk *chk, const char *str)
{
- chk->str = str;
+ chk->str = (char *)str;
chk->len = strlen(str);
chk->size = 0; /* mark it read-only */
}