tree 55a2f66c49e35c81aab36f3559f4dd0460cb412f
parent d638cc8bf7b0f82c18c4876c5d0550c8e7b653d6
author Amaury Denoyelle <adenoyelle@haproxy.com> 1718898844 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1719995265 +0200

BUG/MINOR: quic: fix BUG_ON() on Tx pkt alloc failure

On quic_tx_packet allocation failure, it is possible to trigger BUG_ON()
crash on INITIAL packet building. This statement is responsible to
ensure INITIAL packets are padded to 1.200 bytes as required. If a
packet on higher encryption level allocation fails, PADDING frame cannot
properly encoded, despite the INITIAL packet properly built.

This crash happens due to qc_txb_store() invokation after quic_tx_packet
allocation failure to validate already built packets. However, this
statement is unneeded as qc_purge_tx_buf() is called just after. Simply
remove qc_txb_store() to fix this issue.

This was detected using -dMfail.

This should be backported up to 2.6.

(cherry picked from commit d5376b7a874776b4d5d79f9b746d4654df796f85)
[cf: ctx adjt]
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 078cb85b899eac4fb6774dc47ac2b673933d7cfb)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 06107ea3ab6e2c41c4f8ee3a64a550aa8f932518)
[cf: applied in quic_conn.c in thefunction qc_prep_pkts()]
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>