tree aa7529868fdf5d55d57cbb25ce1ffe938b5e76eb
parent d20dc21eeca1d5e936f7a8bfd3d865a032499c65
author Emeric Brun <ebrun@haproxy.com> 1634719793 +0200
committer Willy Tarreau <w@1wt.eu> 1634745127 +0200
encoding latin1

BUG/MAJOR: dns: attempt to lock globaly for msg waiter list instead of use barrier

The barrier is insufficient here to protect the waiters list as we can
definitely catch situations where ds->waiter shows an inconsistency
whereby the element is not attached when entering the "if" block and
is already attached when attaching it later.

This patch uses a larger lock to maintain consistency. Without it the
code would crash in 30-180 minutes under heavy stress, always showing
the same problem (ds->waiter->n->p != &ds->waiter). Now it seems to
always resist, suggesting that this was indeed the problem.

This will have to be backported to 2.4.