tree d0711aff87c0bd09042f21d01f1e4016f81f1b56
parent c8cac04bd516a5af6fb5a6e967059a90f03c2a99
author Willy Tarreau <w@1wt.eu> 1632287757 +0200
committer Willy Tarreau <w@1wt.eu> 1632288242 +0200
encoding latin1

BUG/MEDIUM: leastconn: fix rare possibility of divide by zero

An optimization was brought in commit 5064ab6a9 ("OPTIM: lb-leastconn:
do not unlink the server if it did not change") to avoid locking the
server just to discover it did not move. However a mistake was made
because the operation involves a divide with a value that is read
outside of its usual lock, which makes it possible to be zero at the
exact moment we watch it if another thread takes the server down under
the lbprm lock, resulting in a divide by zero.

Therefore we must check that the value is not null there.

This must be backported to 2.4.