MINOR: stconn: Remove useless test on sedesc on detach to release the xref
When the SC is detached from the endpoint, the xref between the endpoints is
removed. At this stage, the sedesc cannot be undefined. So we can remove the
test on it.
This issue should fix the issue #2156. No backport needed.
diff --git a/src/stconn.c b/src/stconn.c
index 2339566..3d80b2c 100644
--- a/src/stconn.c
+++ b/src/stconn.c
@@ -351,18 +351,16 @@
static void sc_detach_endp(struct stconn **scp)
{
struct stconn *sc = *scp;
+ struct xref *peer;
if (!sc)
return;
- if (sc->sedesc) {
- struct xref *peer;
- /* Remove my link in the original objects. */
- peer = xref_get_peer_and_lock(&sc->sedesc->xref);
- if (peer)
- xref_disconnect(&sc->sedesc->xref, peer);
- }
+ /* Remove my link in the original objects. */
+ peer = xref_get_peer_and_lock(&sc->sedesc->xref);
+ if (peer)
+ xref_disconnect(&sc->sedesc->xref, peer);
if (sc_ep_test(sc, SE_FL_T_MUX)) {
struct connection *conn = __sc_conn(sc);