tree 31ee72884f090d93db534839ce61dcd6d02603f5
parent 0f727dabf51d4ffead40fd43feb7c07193ebde99
author Willy Tarreau <w@1wt.eu> 1642663910 +0100
committer Willy Tarreau <w@1wt.eu> 1642701417 +0100
encoding latin1

BUG/MEDIUM: mcli: do not try to parse empty buffers

When pcli_parse_request() is called with an empty buffer, it still tries
to parse it and can go on believing it finds an empty request if the last
char before the beginning of the buffer is a '\n'. In this case it overwrites
it with a zero and processes it as an empty command, doing nothing but not
making the buffer progress. This results in an infinite loop that is stopped
by the watchdog. For a reason related to another issue (yet to be fixed),
this can easily be reproduced by pipelining lots of commands such as
"show version".

Let's add a length check after the search for a '\n'.

This needs to be backported as far as 2.0.