tree b3b94e14bb804d17d138f61e53cd5dd3498f22fd
parent c31e2cbd28d53210b7184091bb64137c806d7957
author Olivier Houchard <ohouchard@haproxy.com> 1561393180 +0200
committer Olivier Houchard <cognet@ci0.org> 1561395616 +0200

BUG/MEDIUM: connections: Always add the xprt handshake if needed.

In connect_server(), we used to only call xprt_add_hs() if CO_FL_SEND_PROXY
was set during the function call, we would not do it if the flag was set
before connect_server() was called. The rational at the time was if the flag
was already set, then the XPRT was already present. But now the xprt_handshake
always removes itself, so we have to re-add it each time, or it wouldn't be
done if the first connection attempt failed.
While I'm there, check any non-ssl handshake flag, instead of just
CO_FL_SEND_PROXY, or we'd miss the SOCKS4 flags.

This should be backported to 2.0.