tree 69d63c6d3755624a86ee017b974b2222bb07b22e
parent f411cce456dabbe3cf6637f2bb11435af0499ae7
author Willy Tarreau <w@1wt.eu> 1507135260 +0200
committer Willy Tarreau <w@1wt.eu> 1507135762 +0200
encoding latin1

MEDIUM: checks: make tcpcheck_main() indicate if it recycled a connection

The tcp-checks are very fragile. They can modify a connection's FD by
closing and reopening a socket without informing the connection layer,
which may then possibly touch the wrong fd. Given that the events are
only cleared and that the fd is just created, there should be no visible
side effect because the old fd is deleted so even if its flags get cleared
they were already, and the new fd already has them cleared as well so it's
a NOP. Regardless, this is too fragile and will not resist to threads.

In order to address this situation, this patch makes tcpcheck_main()
indicate if it closed a connection and report it to wake_srv_chk(), which
will then report it to the connection's fd handler so that it refrains
from updating the connection polling and the fd. Instead the connection
polling status is updated in the wake() function.