tree 98bfc0d735f5844970ad4ba402dfe874e3fafdd0
parent 94db44f75db4ffdbb0faaa19ec93ee03d493b432
author Willy Tarreau <w@1wt.eu> 1457446825 +0100
committer Willy Tarreau <w@1wt.eu> 1457451665 +0100
encoding latin1

BUG/MINOR: tcpcheck: fix incorrect list usage resulting in failure to load certain configs

Commit baf9794 ("BUG/MINOR: tcpcheck: conf parsing error when no port
configured on server and first rule(s) is (are) COMMENT") was wrong, it
incorrectly implemented a list access by dereferencing a pointer of an
incorrect type resulting in checking the next element in the list. The
consequence is that it stops before the last comment instead of at the
last one and skips the first rule. In the end, rules starting with
comments are not affected, but if a sequence of checks directly starts
with connect, it is then skipped and this is visible when no port is
configured on the server line as the config refuses to load.

There was another occurence of the same bug a few lines below, both
of them were fixed. Tests were made on different configs and confirm
the new fix is OK.

This fix must be backported to 1.6.
(cherry picked from commit 1a786d7f33267efbbd352b8fb0442f215ee97cfd)
(cherry picked from commit db49e6ef1ee37d33c7ceecd11a1d1af3d99f01b2)