tree 8cf031df0e40acaf638bb556503183f7dd62b927
parent a1fa154c957c3b2f58d174f86ba5dd8f7dd1e2e3
author Amaury Denoyelle <adenoyelle@haproxy.com> 1634543009 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1636552121 +0100

BUG/MEDIUM: mux-h2: reject upgrade if no RFC8441 support

The RFC8441 was not respected by haproxy in regards with server support
for Extended CONNECT. The Extended CONNECT method was used to convert an
Upgrade header stream even if no SETTINGS_ENABLE_CONNECT_PROTOCOL was
received, which is forbidden by the RFC8441. In this case, the behavior
of the http/2 server is unspecified.

Fix this by flagging the connection on receiption of the RFC8441
settings SETTINGS_ENABLE_CONNECT_PROTOCOL. Extended CONNECT is thus only
be used if the flag is present. In the other case, the stream is
immediatly closed as there is no way to handle it in http/2. It results
in a http/1.1 502 or http/2 RESET_STREAM to the client side.

The protocol-upgrade regtest has been extended to test that haproxy does
not emit Extended CONNECT on servers without RFC8441 support.

It must be backported up to 2.4.

(cherry picked from commit 0df043608f53cdb367586714e3ba0a7a3e2b0e89)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>