BUG/MINOR: resolvers: fix attribute packed struct for dns
This patch adds the attribute packed on struct dns_question
because it is directly memcpy to network building a response.
This patch also removes the commented line:
// struct list options; /* list of option records */
because it is also used directly using memcpy to build a request
and must not contain host data.
diff --git a/include/haproxy/dns-t.h b/include/haproxy/dns-t.h
index c919904..b1656b6 100644
--- a/include/haproxy/dns-t.h
+++ b/include/haproxy/dns-t.h
@@ -110,7 +110,7 @@
struct dns_question {
unsigned short qtype; /* question type */
unsigned short qclass; /* query class */
-};
+} __attribute__ ((packed));
/* NOTE: big endian structure */
struct dns_query_item {
@@ -131,7 +131,6 @@
* placeholder here for this purpose. We may need to define a dns_option_record
* structure which itself should point to different type of data, based on the
* extension set (client subnet, tcp keepalive, etc...)*/
-// struct list options; /* list of option records */
} __attribute__ ((packed));
/* NOTE: big endian structure */