tree a188b53429806facb51b415061678089a57ceb88
parent 7651362e52af556e900e461c0c5c0d87a8c3c51a
author Christopher Faulet <cfaulet@haproxy.com> 1579777051 +0100
committer Christopher Faulet <cfaulet@haproxy.com> 1580997334 +0100

BUG/MINOR: http-ana: Don't overwrite outgoing data when an error is reported

When an error is returned to a client, the right message is injected into the
response buffer. It is performed by http_server_error() or
http_replay_and_close(). Both ignore any data already present into the channel's
buffer. While it is legitimate to remove all input data, it is important to not
remove any outgoing data.

So now, we try to append the error message to the response buffer, only removing
input data. We rely on the channel_htx_copy_msg() function to do so. So this
patch depends on the following two commits:

  * MINOR: htx: Add a function to append an HTX message to another one
  * MINOR: htx/channel: Add a function to copy an HTX message in a channel's buffer

This patch must be backported as far as 1.9. However, above patches must be
backported first.