CLEANUP: tree-wide: replace free(x);x=NULL with ha_free(&x)
This makes the code more readable and less prone to copy-paste errors.
In addition, it allows to place some __builtin_constant_p() predicates
to trigger a link-time error in case the compiler knows that the freed
area is constant. It will also produce compile-time error if trying to
free something that is not a regular pointer (e.g. a function).
The DEBUG_MEM_STATS macro now also defines an instance for ha_free()
so that all these calls can be checked.
178 occurrences were converted. The vast majority of them were handled
by the following Coccinelle script, some slightly refined to better deal
with "&*x" or with long lines:
@ rule @
expression E;
@@
- free(E);
- E = NULL;
+ ha_free(&E);
It was verified that the resulting code is the same, more or less a
handful of cases where the compiler optimized slightly differently
the temporary variable that holds the copy of the pointer.
A non-negligible amount of {free(str);str=NULL;str_len=0;} are still
present in the config part (mostly header names in proxies). These
ones should also be cleaned for the same reasons, and probably be
turned into ist strings.
diff --git a/src/mworker-prog.c b/src/mworker-prog.c
index acf84b0..4113b7c 100644
--- a/src/mworker-prog.c
+++ b/src/mworker-prog.c
@@ -307,18 +307,14 @@
int i;
for (i = 0; ext_child->command[i]; i++) {
- free(ext_child->command[i]);
- ext_child->command[i] = NULL;
+ ha_free(&ext_child->command[i]);
}
- free(ext_child->command);
- ext_child->command = NULL;
+ ha_free(&ext_child->command);
}
- free(ext_child->id);
- ext_child->id = NULL;
+ ha_free(&ext_child->id);
}
- free(ext_child);
- ext_child = NULL;
+ ha_free(&ext_child);
out:
return err_code;