MINOR: httpclient/lua: return an error when it can't generate the request
Add a check during the httpclient request generation which yield an lua
error when the generation didn't work. The most common case is the lack
of space in the buffer, it can because of too much headers or a too big
body.
diff --git a/src/hlua.c b/src/hlua.c
index d3c7684..27c6216 100644
--- a/src/hlua.c
+++ b/src/hlua.c
@@ -7209,8 +7209,7 @@
hlua_hc->hc->ops.res_end = hlua_httpclient_res_cb;
- httpclient_req_gen(hlua_hc->hc, hlua_hc->hc->req.url, meth, hdrs, ist(body_str));
- httpclient_start(hlua_hc->hc);
+ ret = httpclient_req_gen(hlua_hc->hc, hlua_hc->hc->req.url, meth, hdrs, ist(body_str));
/* free the temporary headers array */
hdrs_i = hdrs;
@@ -7222,7 +7221,14 @@
ha_free(&hdrs);
+ if (ret != ERR_NONE) {
+ WILL_LJMP(luaL_error(L, "Can't generate the HTTP request"));
+ return 0;
+ }
+
+ httpclient_start(hlua_hc->hc);
+
/* we return a "res" object */
lua_newtable(L);