MEDIUM: hathreads: implement a more flexible rendez-vous point
The current synchronization point enforces certain restrictions which
are hard to workaround in certain areas of the code. The fact that the
critical code can only be called from the sync point itself is a problem
for some callback-driven parts. The "show fd" command for example is
fragile regarding this.
Also it is expensive in terms of CPU usage because it wakes every other
thread just to be sure all of them join to the rendez-vous point. It's a
problem because the sleeping threads would not need to be woken up just
to know they're doing nothing.
Here we implement a different approach. We keep track of harmless threads,
which are defined as those either doing nothing, or doing harmless things.
The rendez-vous is used "for others" as a way for a thread to isolate itself.
A thread then requests to be alone using thread_isolate() when approaching
the dangerous area, and then waits until all other threads are either doing
the same or are doing something harmless (typically polling). The function
only returns once the thread is guaranteed to be alone, and the critical
section is terminated using thread_release().
diff --git a/src/ev_epoll.c b/src/ev_epoll.c
index abc22ba..f672c66 100644
--- a/src/ev_epoll.c
+++ b/src/ev_epoll.c
@@ -17,6 +17,7 @@
#include <common/config.h>
#include <common/debug.h>
#include <common/epoll.h>
+#include <common/hathreads.h>
#include <common/standard.h>
#include <common/ticks.h>
#include <common/time.h>
@@ -141,6 +142,8 @@
_update_fd(fd);
}
+ thread_harmless_now();
+
/* compute the epoll_wait() timeout */
if (!exp)
wait_time = MAX_DELAY_MS;
@@ -161,6 +164,8 @@
tv_update_date(wait_time, status);
measure_idle();
+ thread_harmless_end();
+
/* process polled events */
for (count = 0; count < status; count++) {