tree e28df22e6ecdfc05aaf2cd97847d02c90c846416
parent 25174d51efbcda6d94bb2ebab786e0e191c069ce
author Amaury Denoyelle <adenoyelle@haproxy.com> 1681217022 +0200
committer Amaury Denoyelle <adenoyelle@haproxy.com> 1681830542 +0200

BUG/MINOR: quic: transform qc_set_timer() as a reentrant function

qc_set_timer() function is used to rearm the timer for loss detection
and probing. Previously, timer was always rearm when congestion window
was free due to a wrong interpretation of the RFC which mandates the
client to rearm the timer before handshake completion to avoid a
deadlock related to anti-amplification.

Fix this by removing this code from quic_pto_pktns(). This allows
qc_set_timer() to be reentrant and only activate the timer if needed.

The impact of this bug seems limited. It can probably caused the timer
task to be processed too frequently which could caused too frequent
probing.

This change will allow to reuse easily qc_set_timer() after quic_conn
thread migration. As such, the new timer task will be scheduled only if
needed.

This should be backported up to 2.6.