tree 7f6343f6159e8b3117ecfc5ea8a9c60edc5da000
parent ff85390d3af8a61d4e4b2969ac6f9beff5be3dd0
author Willy Tarreau <w@1wt.eu> 1471168975 +0200
committer Willy Tarreau <w@1wt.eu> 1475759804 +0200
encoding latin1

BUG/MAJOR: stick-counters: possible crash when using sc_trackers with wrong table

Bryan Talbot reported a very interesting bug. The sc_trackers() sample
fetch seems to have escaped the sanitization that was performed during 1.5
to ensure all dereferences of stkctr_entry() were safe. Here if a tacker
is set on a backend and is then checked against a different backend where
the entry doesn't exist, stkctr_entry() returns NULL and this is dereferenced
to retrieve the ref count. Thanks to Bryan for his detailed bug report featuring
a working config and reproducer.

This fix must be backported to 1.6 and 1.5.

(cherry picked from commit 4d03ef7f0319c5f73cbcb1d5c3025923226a1536)
(cherry picked from commit 89e3864c224c61369e9e33e31c53576bdc80ed6a)