MEDIUM: pools: add a new flag to avoid rounding pool size up
Usually it's desirable to merge similarly sized pools, which is the
reason why their size is rounded up to the next multiple of 16. But
for the buffers this is problematic because we add the size of
struct buffer to the user-requested size, and the rounding results
in 8 extra bytes that are usable in the end. So the user gets more
bytes than asked for, and in case of SSL it results in short writes
for the extra bytes that are sent above multiples of 16 kB.
So we add a new flag MEM_F_EXACT to request that the size is not
rounded up when creating the entry. Thus it doesn't disable merging.
diff --git a/src/memory.c b/src/memory.c
index 036f786..53ab489 100644
--- a/src/memory.c
+++ b/src/memory.c
@@ -24,7 +24,9 @@
/* Try to find an existing shared pool with the same characteristics and
* returns it, otherwise creates this one. NULL is returned if no memory
- * is available for a new creation.
+ * is available for a new creation. Two flags are supported :
+ * - MEM_F_SHARED to indicate that the pool may be shared with other users
+ * - MEM_F_EXACT to indicate that the size must not be rounded up
*/
struct pool_head *create_pool(char *name, unsigned int size, unsigned int flags)
{
@@ -41,8 +43,10 @@
* so that the visible parts outside are not affected.
*/
- align = 16;
- size = ((size + POOL_EXTRA + align - 1) & -align) - POOL_EXTRA;
+ if (!(flags & MEM_F_EXACT)) {
+ align = 16;
+ size = ((size + POOL_EXTRA + align - 1) & -align) - POOL_EXTRA;
+ }
start = &pools;
pool = NULL;