MINOR: stream-int: make it clear that si_ops cannot be null
There was an ambiguity in which functions of the si_ops struct could be
null or not. only ->update doesn't exist in one of the si_ops (the
embedded one), all others are always defined. ->shutr and ->shutw were
never tested. However ->chk_rcv() and ->chk_snd() were tested, causing
confusion about the proper way to wake the other side up if undefined
(which never happens).
Let's update the comments to state these functions are mandatory and
remove the offending checks.
diff --git a/include/proto/stream_interface.h b/include/proto/stream_interface.h
index c2c5310..7bab7ff 100644
--- a/include/proto/stream_interface.h
+++ b/include/proto/stream_interface.h
@@ -388,15 +388,13 @@
/* Calls chk_rcv on the connection using the data layer */
static inline void si_chk_rcv(struct stream_interface *si)
{
- if (si->ops->chk_rcv)
- si->ops->chk_rcv(si);
+ si->ops->chk_rcv(si);
}
/* Calls chk_snd on the connection using the data layer */
static inline void si_chk_snd(struct stream_interface *si)
{
- if (si->ops->chk_snd)
- si->ops->chk_snd(si);
+ si->ops->chk_snd(si);
}
/* Calls chk_snd on the connection using the ctrl layer */