tree 4420a363fe107a0745861adefef257231ad1b4a8
parent 29962f700084fc7b1aef6bbdb28a1c2387a418c2
author Christopher Faulet <cfaulet@haproxy.com> 1659519115 +0200
committer Willy Tarreau <w@1wt.eu> 1660323169 +0200
encoding latin1

BUG/MEDIUM: proxy: Perform a custom copy for default server settings

When a proxy is initialized with the settings of the default proxy, instead
of doing a raw copy of the default server settings, a custom copy is now
performed by calling srv_settings_copy(). This way, all settings will be
really duplicated. Without this deep copy, some pointers are shared between
several servers, leading to UAF, double-free or such bugs.

This patch relies on following commits:

  * b32cb9b51 REORG: server: Export srv_settings_cpy() function
  * 0b365e3cb MINOR: server: Constify source server to copy its settings

This patch should fix the issue #1804. It must be backported as far as 2.0.

(cherry picked from commit 6bb86539dbe66b79e011b287c8b750f2e4ee62a0)
Signed-off-by: Willy Tarreau <w@1wt.eu>
(cherry picked from commit e75f1d3d04e6153d01fad3e79c8bc38b3f3e8ea9)
Signed-off-by: Willy Tarreau <w@1wt.eu>
(cherry picked from commit bba6ec9c3e377fb5475cf6c415dcf48473a7a9f1)
Signed-off-by: Willy Tarreau <w@1wt.eu>