tree 66119b321a19e9f6ba27385f29d2ce0dbbfbbcf0
parent e2370307bee0098bc9bbca51788322f3f3dc4dbc
author Willy Tarreau <w@1wt.eu> 1603537061 +0200
committer Willy Tarreau <w@1wt.eu> 1603537061 +0200
encoding latin1

BUG/MEDIUM: queue: fix unsafe proxy pointer when counting nbpend

As reported by Coverity in issue #917, commit 96bca33 ("OPTIM: queue:
decrement the nbpend and totpend counters outside of the lock")
introduced a bug when moving the increments outside of the loop,
because we can't always rely on the pendconn "p" here as it may
be null. We can retrieve the proxy pointer directly from s->proxy
instead. The same is true for pendconn_redistribute(), though the
last "p" pointer there was still valid. This patch fixes both.

No backport is needed, this was introduced just before 2.3-dev8.