tree 79f42ea2ce32e80696a626beedf36b57a13650c1
parent 2b85a649c7d15d285075ecae703b97df81226209
author Aurelien DARRAGON <adarragon@haproxy.com> 1710771488 +0100
committer Christopher Faulet <cfaulet@haproxy.com> 1711723650 +0100

OPTIM: http_ext: avoid useless copy in http_7239_extract_{ipv4,ipv6}

In http_7239_extract_{ipv4,ipv6}, we declare a local buffer in order to
use inet_pton() since it requires a valid destination argument (cannot be
NULL). Then, if the caller provided <ip> argument, we copy inet_pton()
result (from local buffer to <ip>).

In fact when the caller provides <ip>, we may directly use <ip> as
inet_pton() dst argument to avoid an useless copy. Thus the local buffer
is only relevant when the user doesn't provide <ip>.

While at it, let's add a missing testcase for the rfc7239_n2nn converter
(to check that http_7239_extract_ipv4() with <ip> provided works properly)

This could be backported in 2.8 with b2bb925 ("MINOR: proxy/http_ext:
introduce proxy forwarded option")

(cherry picked from commit db1cd8f8819b59f599b6e5f407816db52c8e7ae6)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 64e47a2ab17ba58e6b3883bc73811d77561b26a8)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>