commit 51e01b56ec616c17b960e0862549c9a2aca59aae
author Frédéric Lécaille <flecaille@haproxy.com> Thu Nov 29 21:41:42 2018 +0100
committer Willy Tarreau <w@1wt.eu> Fri Nov 30 05:58:45 2018 +0100
tree 92a78c44dea7485498f7ebc41bc5add88b66c969
parent 4667773a8afb7324b96c9326086538826aa42a5b

REGTEST: Fix several issues.

Use #!bin/sh more portable shebang.
Support filenames with spaces.
Set HAPROXY_PROGRAM environment variable value to ${PWD}/haproxy.
exit(1) if we could not creat the higher level temporary working directory
or create its sub-directory with mktemp utility.
As defined by POSIX, use six characters for the mktemp template.

scripts/run-regtests.sh

diff --git a/scripts/run-regtests.sh b/scripts/run-regtests.sh
index 5add854..d05d8de 100755
--- a/scripts/run-regtests.sh
+++ b/scripts/run-regtests.sh
@@ -1,4 +1,4 @@
-#!/usr/bin/env sh
+#!/bin/sh
 
 if [ "$1" = "--help" ]; then
   cat << EOF
@@ -180,8 +180,8 @@
 echo ""
 echo "########################## Preparing to run tests ##########################"
 
-HAPROXY_PROGRAM=${HAPROXY_PROGRAM:-haproxy}
-VARNISHTEST_PROGRAM=${VARNISHTEST_PROGRAM:-varnishtest}
+HAPROXY_PROGRAM="${HAPROXY_PROGRAM:-${PWD}/haproxy}"
+VARNISHTEST_PROGRAM="${VARNISHTEST_PROGRAM:-varnishtest}"
 
 preparefailed=
 if ! [ -x "$(command -v $HAPROXY_PROGRAM)" ]; then
@@ -205,12 +205,12 @@
 
 TESTRUNDATETIME="$(date '+%Y-%m-%d_%H-%M-%S')"
 
-TESTDIR=${TMPDIR:-/tmp}/varnishtest_haproxy
-mkdir -p "$TESTDIR"
-TESTDIR=$(mktemp -d $TESTDIR/$TESTRUNDATETIME.XXXX)
+TESTDIR="${TMPDIR:-/tmp}"
+mkdir -p "$TESTDIR" || exit 1
+TESTDIR=$(mktemp -d "$TESTDIR/$TESTRUNDATETIME.XXXXXX") || exit 1
 
-export TMPDIR=$TESTDIR
-export HAPROXY_PROGRAM=$HAPROXY_PROGRAM
+export TMPDIR="$TESTDIR"
+export HAPROXY_PROGRAM="$HAPROXY_PROGRAM"
 
 # Mimic implicit build options from haproxy MakeFile that are present for each target:
 
@@ -300,18 +300,18 @@
 if [ $_vtresult != 0 ]
 then
   echo "########################## Gathering failed results ##########################"
-  for i in $(find $TESTDIR/ -type d -name "vtc.*");
-  do
-    cat <<- EOF | tee $TESTDIR/failedtests.log
-$(echo "###### $(cat $i/INFO) ######")
-$(echo "## test results in: $i")
-$(grep -- ---- $i/LOG)
-
+  export TESTDIR
+  find "$TESTDIR" -type d -name "vtc.*" -exec sh -c 'for i; do
+    if [ ! -e "$i/LOG" ] ; then continue; fi
+    cat <<- EOF | tee -a "$TESTDIR/failedtests.log"
+$(echo "###### $(cat "$i/INFO") ######")
+$(echo "## test results in: \"$i\"")
+$(grep -- ---- "$i/LOG")
 EOF
-  done
+  done' sh {} +
   exit 1
 else
   # all tests were succesfull, removing tempdir (the last part.)
-  rm -d $TESTDIR
+  rmdir "$TESTDIR"
 fi
 exit 0