BUG/MINOR: mux-h1: Be sure to commit htx changes in the demux buffer
When a buffer area is casted to an htx message, depending on the method
used, the underlying buffer may be updated or not. The htxbuf() function
does not change the buffer state. We assume the buffer was already prepared
to store an htx message. htx_from_buf() on its side, updates the
buffer. With the first function, we only need to commit changes to the
underlying buffer if the htx message is changed. With last one, we must
always commit the changes. The idea is to be sure to keep non-empty HTX
messages while an empty message must be lead to an empty buffer after
commit.
All that said because in h1_process_demux(), the changes is not always
committed as expected. When the demux is blocked, we just leave the
function. So it is possible to have an empty htx message stored in a buffer
that appears non-empty. It is not critical, but the buffer cannot be
released in this state. And we should always release an empty buffer.
This patch must be backported as far as 2.4.
(cherry picked from commit 5966e4064156a10bca3a3051eb0a19b40c1ad0ed)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 53fa7eb90a51016c46e2d7528f28ca2611686bea)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 6e45613d88fe19b52c2c47e16285c8015bf99ae9)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
1 file changed