tree 69068e9d2decef7fe0a8d3e88486a7327751a023
parent d79422a0ffa8ed926326496f45105e4132ebf5f0
author Willy Tarreau <w@1wt.eu> 1593296357 +0200
committer Willy Tarreau <w@1wt.eu> 1593334356 +0200
encoding latin1

MINOR: connection: align toremove_{lock,connections} and cleanup into idle_conns

We used to have 3 thread-based arrays for toremove_lock, idle_cleanup,
and toremove_connections. The problem is that these items are small,
and that this creates false sharing between threads since it's possible
to pack up to 8-16 of these values into a single cache line. This can
cause real damage where there is contention on the lock.

This patch creates a new array of struct "idle_conns" that is aligned
on a cache line and which contains all three members above. This way
each thread has access to its variables without hindering the other
ones. Just doing this increased the HTTP/1 request rate by 5% on a
16-thread machine.

The definition was moved to connection.{c,h} since it appeared a more
natural evolution of the ongoing changes given that there was already
one of them declared in connection.h previously.