MINOR: dynbuf: pass offer_buffers() the number of buffers instead of a threshold
Historically this function would try to wake the most accurate number of
process_stream() waiters. But since the introduction of filters which could
also require buffers (e.g. for compression), things started not to be as
accurate anymore. Nowadays muxes and transport layers also use buffers, so
the runqueue size has nothing to do anymore with the number of supposed
users to come.
In addition to this, the threshold was compared to the number of free buffer
calculated as allocated minus used, but this didn't work anymore with local
pools since these counts are not updated upon alloc/free!
Let's clean this up and pass the number of released buffers instead, and
consider that each waiter successfully called counts as one buffer. This
is not rocket science and will not suddenly fix everything, but at least
it cannot be as wrong as it is today.
This could have been marked as a bug given that the current situation is
totally broken regarding this, but this probably doesn't completely fix
it, it only goes in a better direction. It is possible however that it
makes sense in the future to backport this as part of a larger series if
the situation significantly improves.
diff --git a/src/flt_spoe.c b/src/flt_spoe.c
index eee77cb..92a5af4 100644
--- a/src/flt_spoe.c
+++ b/src/flt_spoe.c
@@ -2841,7 +2841,7 @@
/* Release the buffer if needed */
if (buf->size) {
b_free(buf);
- offer_buffers(buffer_wait->target, tasks_run_queue);
+ offer_buffers(buffer_wait->target, 1);
}
}