commit 4cb1637b72975c9d9e819b03d01453b860340686
author Willy Tarreau <w@1wt.eu> Wed Oct 16 09:44:55 2019 +0200
committer Christopher Faulet <cfaulet@haproxy.com> Wed Oct 16 10:34:19 2019 +0200
tree a0e2d740364f849d24abd46e7022021abe24af71
parent 5e1c1468789d80213325054b6fc1dbd1c70d7776

MINOR: version: make the version strings variables, not constants

It currently is not possible to figure the exact haproxy version from a
core file for the sole reason that the version is stored into a const
string and as such ends up in the .text section that is not part of a
core file. By turning them into variables we move them to the data
section and they appear in core files. In order to help finding them,
we just prepend an extra variable in front of them and we're able to
immediately spot the version strings from a core file:

  $ strings core | fgrep -A2 'HAProxy version'
  HAProxy version follows
  2.1-dev2-e0f48a-88
  2019/10/15

(These are haproxy_version and haproxy_date respectively). This may be
backported to 2.0 since this part is not support to impact anything but
the developer's time spent debugging.

(cherry picked from commit abefa34c344b7aa2c38654664c2dd170d50e3b2e)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>

include/common/version.h

diff --git a/include/common/version.h b/include/common/version.h
index 305087d..ec25aab 100644
--- a/include/common/version.h
+++ b/include/common/version.h
@@ -66,9 +66,9 @@
 #error "Must define CONFIG_HAPROXY_DATE"
 #endif
 
-extern const char *haproxy_version;
-extern const char *haproxy_date;
-extern const char *stats_version_string;
+extern char haproxy_version[];
+extern char haproxy_date[];
+extern char stats_version_string[];
 
 #endif /* _COMMON_VERSION_H */
 

src/version.c

diff --git a/src/version.c b/src/version.c
index f50f24b..dae7b3d 100644
--- a/src/version.c
+++ b/src/version.c
@@ -6,6 +6,10 @@
 
 #include <common/version.h>
 
-const char *haproxy_version      = HAPROXY_VERSION;
-const char *haproxy_date         = HAPROXY_DATE;
-const char *stats_version_string = STATS_VERSION_STRING;
+/* These ones are made variables and not constants so that they are stored into
+ * the data region and prominently appear in core files.
+ */
+char haproxy_version_here[] = "HAProxy version follows";
+char haproxy_version[]      = HAPROXY_VERSION;
+char haproxy_date[]         = HAPROXY_DATE;
+char stats_version_string[] = STATS_VERSION_STRING;