tree bfe729a21f4c86d22d88d216ff8b682c6f26252d
parent ffcd290dddd04603871e63718fca3b4db3f4fa82
author Amaury Denoyelle <adenoyelle@haproxy.com> 1613573942 +0100
committer Amaury Denoyelle <adenoyelle@haproxy.com> 1613576300 +0100

BUG/MINOR: backend: do not call smp_make_safe for sni conn hash

conn_hash_prehash does not need a nul-terminated string, thus it is only
needed to test if the sni sample is not null before using it as
connection hash input.

Moreover, a bug could be introduced between smp_make_safe and
ssl_sock_set_servername call. Indeed, smp_make_safe may call smp_dup
which duplicates the sample in the trash buffer. If another function
manipulates the trash buffer before the call to ssl_sock_set_servername,
the sni sample might be erased. Currently, no function seems to do that
except make_proxy_line in case proxy protocol is used simultaneously
with the sni on the server.

This does not need to be backported.