tree e40967ea27a0cdff26b87cd19f3f38354e2a6ee2
parent f8340e38bf1830a37b6b934d77210246b93d7cbf
author Willy Tarreau <w@1wt.eu> 1569480435 +0200
committer Willy Tarreau <w@1wt.eu> 1569480435 +0200
encoding latin1

BUG/MEDIUM: mux-h2: don't reject valid frames on closed streams

Consecutive to commit 6884aa3eb0 ("BUG/MAJOR: mux-h2: Handle HEADERS frames
received after a RST_STREAM frame") some valid frames on closed streams
(RST_STREAM, PRIORITY, WINDOW_UPDATE) were now rejected. It turns out that
the previous condition was in fact intentional to catch only sensitive
frames, which was indeed a mistake since these ones needed to be decoded
to keep HPACK synchronized. But we must absolutely accept WINDOW_UPDATES
or we risk to stall some transfers. And RST/PRIO definitely are valid.

Let's adjust the condition to reflect that and update the comment to
explain the reason for this unobvious condition.

This must be backported to 2.0 and 1.9 after the commit above is brought
there.