tree 4a3c2d1ce7ea21dd7531bc62bc8c32d70eb6dca7
parent 06f6811d9fc3f36597b686e4ca9fe7fbccf091b0
author Ricardo Nabinger Sanchez <rnsanchez@taghos.com.br> 1553820143 -0300
committer Willy Tarreau <w@1wt.eu> 1553854355 +0100
encoding latin1

BUG/MAJOR: checks: segfault during tcpcheck_main

When using TCP health checks (tcp-check connect), it is possible to
crash with a segfault when, for reasons yet to be understood, the
protocol family is unknown.

In the function tcpcheck_main(), proto is dereferenced without a prior
test in case it is NULL, leading to the segfault during proto->connect
dereference.

The line has been unmodified since it was introduced, in commit
69e273f3fcfbfb9cc0fb5a09668faad66cfbd36b.  This was the only use of
proto (or more specifically, the return of  protocol_by_family()) that
was unprotected; all other callsites perform the test for a NULL
pointer.

This patch should be backported to 1.9, 1.8, 1.7, and 1.6.