tree f16f9425df140e2782df170723cfa633417aba1d
parent 9dde0b2d31dd0e588a6fcd34ca8b6dd6cee73e3d
author Jerome Magnin <jmagnin@haproxy.com> 1582277868 +0100
committer Willy Tarreau <w@1wt.eu> 1582282334 +0100
encoding latin1

BUG/MINOR: http: http-request replace-path duplicates the query string

In http_action_replace_uri() we call http_get_path() in the case of
a replace-path rule. http_get_path() will return an ist pointing to
the start of the path, but uri.ptr + uri.len points to the end of the
uri. As as result, we are matching against a string containing the
query, which we append to the "path" later, effectively duplicating
the query string.

This patch uses the iststop() function introduced in "MINOR: ist: add
an iststop() function" to find the '?' character and update the ist
length when needed.

This fixes issue #510.

The bug was introduced by commit 262c3f1a ("MINOR: http: add a new
"replace-path" action"), which was backported to 2.1 and 2.0.