tree 38d9db894214fdde5b4f7aa466f7afa331647461
parent 85a7ea0740d7a0479d9a3f97e02f2e53c473a85f
author Willy Tarreau <w@1wt.eu> 1556617423 +0200
committer Willy Tarreau <w@1wt.eu> 1556617859 +0200
encoding latin1

BUG/MAJOR: map/acl: real fix segfault during show map/acl on CLI

A previous commit 8d85aa44d ("BUG/MAJOR: map: fix segfault during
'show map/acl' on cli.") was provided to address a concurrency issue
between "show acl" and "clear acl" on the CLI. Sadly the code placed
there was copy-pasted without changing the element type (which was
struct stream in the original code) and not tested since the crash
is still present.

The reproducer is simple : load a large ACL file (e.g. geolocation
addresses), issue "show acl #0" in loops in one window and issue a
"clear acl #0" in the other one, haproxy crashes.

This fix was also tested with threads enabled and looks good since
the locking seems to work correctly in these areas though. It will
have to be backported as far as 1.6 since the commit above went
that far as well...