tree e0c12027d5592706355a9f113aed1b79a629fe4c
parent 21a796cb83c29ee276feb04649a1b18214bbdee0
author Willy Tarreau <w@1wt.eu> 1564146639 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1564392022 +0200

BUG/MINOR: log: make sure writev() is not interrupted on a file output

Since 1.9 we support sending logs to various non-blocking outputs like
stdou/stderr or flies, by using writev() which guarantees that it only
returns after having written everything or nothing. However the syscall
may be interrupted while doing so, and this is visible when writing to
a tty during debug sessions, as some logs occasionally appear interleaved
if an xterm or SSH connection is not very fast. Performance here is not a
critical concern, log correctness is. Let's simply take the logger's lock
around the writev() call to prevent multiple senders from stepping onto
each other's toes.

This may be backported to 2.0 and 1.9.

(cherry picked from commit 9fbcb7e2e9c32659ab11927394fec2e160be2d0b)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>