tree d67d51b20fc10966680e57b34481170f67bf7f39
parent be7c5524473c7bc56ba4af19eb90e2cfda52e8b3
author Christopher Faulet <cfaulet@haproxy.com> 1576578346 +0100
committer Christopher Faulet <cfaulet@haproxy.com> 1579768122 +0100

BUG/MINOR: http-rules: Remove buggy deinit functions for HTTP rules

Functions to deinitialize the HTTP rules are buggy. These functions does not
check the action name to release the right part in the arg union. Only few info
are released. For auth rules, the realm is released and there is no problem
here. But the regex <arg.hdr_add.re> is always unconditionally released. So it
is easy to make these functions crash. For instance, with the following rule
HAProxy crashes during the deinit :

      http-request set-map(/path/to/map) %[src] %[req.hdr(X-Value)]

For now, These functions are simply removed and we rely on the deinit function
used for TCP rules (renamed as deinit_act_rules()). This patch fixes the
bug. But arguments used by actions are not released at all, this part will be
addressed later.

This patch must be backported to all stable versions.

(cherry picked from commit cb5501327c7ece8a9b5b07c9a839419e45d9ee4a)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit ff9be052e36d427df467b4a9b2f0a9b79af481a4)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>