tree 7dbf90978cdf6d0ace5e60bb9f3819fdc83f2011
parent 413e926ba28286aeb53b6a8449aa64d0937eba23
author Christopher Faulet <cfaulet@haproxy.com> 1562852425 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1562919123 +0200

BUG/MEDIUM: mux-h1: Don't release h1 connection if there is still data to send

When the h1 stream (h1s) is detached, If the connection is not really shutdown
yet and if there is still some data to send, the h1 connection (h1c) must not be
released. Otherwise, the remaining data are lost. This bug was introduced by the
commit 3ac0f430 ("BUG/MEDIUM: mux-h1: Always release H1C if a shutdown for
writes was reported").

Here is the conditions to release an h1 connection when the h1 stream is
detached :

  * An error or a shutdown write occurred on the connection
    (CO_FL_ERROR|CO_FL_SOCK_WR_SH)

  * an error, an h2 upgrade or full shutdown occurred on the h1 connection
    (H1C_F_CS_ERROR||H1C_F_UPG_H2C|H1C_F_CS_SHUTDOWN)

  * A shutdown write is pending on the h1 connection and there is no more data
    in the output buffer
    ((h1c->flags & H1C_F_CS_SHUTW_NOW) && !b_data(&h1c->obuf))

If one of these conditions is fulfilled, the h1 connection is
released. Otherwise, the release is delayed. If we are waiting to send remaining
data, a timeout is set.

This patch must be backported to 2.0 and 1.9. It fixes the issue #164.

(cherry picked from commit 37243bc61f9c5cf88d1fe96a016e5f2f7e5e0c60)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>