tree c64db46a7a563ac77161293296c3288d8bb6dff4
parent 50603267981a002d2593bfe219e5071d66a8ea65
author Willy Tarreau <w@1wt.eu> 1576574729 +0100
committer Willy Tarreau <w@1wt.eu> 1576575889 +0100
encoding latin1

BUG/MINOR: sample: always check converters' arguments

In 1.5-dev20, sample-fetch arguments parsing was addresse by commit
689a1df0a1 ("BUG/MEDIUM: sample: simplify and fix the argument parsing").
The issue was that argument checks were not run for sample-fetches if
parenthesis were not present. Surprisingly, the fix was mde only for
sample-fetches and not for converters which suffer from the exact same
problem. There are even a few comments in the code mentioning that some
argument validation functions are not called when arguments are missing.

This fix applies the exact same method as the one above. The impact of
this bug is limited because over the years the code has learned to work
around this issue instead of fixing it.

This may be backported to all maintained versions.