tree f8c90057e75220d65fbb551e1cb861d99ac074b0
parent 4629d0831e7511eaba3b6a6f00a04a57e1a7e628
author Christopher Faulet <cfaulet@haproxy.com> 1562234382 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1562329887 +0200

BUG/MEDIUM: lb_fas: Don't test the server's lb_tree from outside the lock

In the function fas_srv_reposition(), the server's lb_tree is tested from
outside the lock. So it is possible to remove it after the test and then call
eb32_insert() in fas_queue_srv() with a NULL root pointer, which is
invalid. Moving the test in the scope of the lock fixes the bug.

This issue was reported on Github, issue #126.

This patch must be backported to 2.0, 1.9 and 1.8.

(cherry picked from commit 16b2be93ad9e7db2d57ca5aaa4ca629efecd6530)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>