MINOR: http-htx: add BUG_ON to prevent API error on http_cookie_register
http_cookie_register() must be called on first invocation with the last
two arguments pointing both to a negative value. After it, they will be
updated to a valid index.
We must never have only the last argument as NULL as this will cause an
invalid array addressing. To clarify this a BUG_ON statement is
introduced.
This is linked to github issue #1967.
diff --git a/src/http_htx.c b/src/http_htx.c
index 5cb0b29..2978f2e 100644
--- a/src/http_htx.c
+++ b/src/http_htx.c
@@ -1817,6 +1817,11 @@
* the next one. The last entry will contains -1.
*/
+ /* Caller is responsible to initialize *first and *last to -1 on first
+ * invocation. Both will thus be set to a valid index after it.
+ */
+ BUG_ON(*first > 0 && *last < 0);
+
/* Mark the current end of cookie linked list. */
list[idx].n.len = -1;
if (*first < 0) {