tree a7b4a0ac45665205b194deec7cdb1a6f3628a515
parent 9f4f6b038c04f5090d5100db5840bedbaa530787
author Amaury Denoyelle <adenoyelle@haproxy.com> 1663080561 +0200
committer Amaury Denoyelle <adenoyelle@haproxy.com> 1663663619 +0200

BUG/MINOR: mux-quic: do not keep detached qcs with empty Tx buffers

A qcs instance free may be postponed in stream detach operation if the
stream is not locally closed. This condition is there to achieve
transfering data still present in Tx buffer. Once all data have been
emitted to quic-conn layer, qcs instance can be released.

However, the stream is only closed locally if HTX EOM has been seen or
it has been resetted. In case the transfer finished without EOM, a
detached qcs won't be freed even if there is no more activity on it.

This bug was not reproduced but was found on code analysis. Its precise
impact is unknown but it should not cause any leak as all qcs instances
are freed with its parent qcc connection : this should eventually happen
on MUX timeout or QUIC idle timeout.

To adjust this, condition to mark a stream as locally closed has been
extended. On qcc_streams_sent_done() notification, if its Tx buffer has
been fully transmitted, it will be closed if either FIN STREAM was set
or the stream is detached.

This must be backported up to 2.6.