tree a95ca0dd8adb8c6c5a2a861224c301163fe8a3fc
parent a4fc3a5771d7fd4a3a9a3efe7ee072f101a33a4a
author Valentine Krasnobaeva <vkrasnobaeva@haproxy.com> 1723051869 +0200
committer Willy Tarreau <w@1wt.eu> 1725550197 +0200
encoding latin1

BUG/MINOR: proto_tcp: delete fd from fdtab if listen() fails

If listen() fails, fd should be deleted from fdtab, not just closed. Otherwise,
sock_inet_bind_receiver(), which is called in loop for each receiver, will
obtain the same fd via socket() for the next receiver, registered in the
receivers list. Then, it will bind it again and it will try to re-insert it in
fdtab, and fd_insert() will trigger the BUG_ON(fdtab[fd].owner != NULL) check.

When tcp_bind_listener() code was implemented, the use of fd_delete() was
not generalized and this one remained overlooked.

This can be backported to all stable versions.

(cherry picked from commit 308c6881c03b6302afd5cc48781d73a11ef994d4)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit de397e2e9795d2b7a240e8e78b243014d11738e1)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 66ff6a3286c3182a42d6d2717b0980c1dd92acd5)
Signed-off-by: Willy Tarreau <w@1wt.eu>