tree add94f74e69374d506a6485a3ba3916f18614a8e
parent e0ca6ad00a42e0448e56ebf144e53043c22f75b5
author Christopher Faulet <cfaulet@haproxy.com> 1593783491 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1594130293 +0200

BUG/MEDIUM: mux-h1: Subscribe rather than waking up in h1_rcv_buf()

At the end of h1_rcv_buf(), if the message was not fully processed (not in
HTTP_MSG_DONE state), it means some data are missing. But instead of waking up
the H1 connection, it is safer to subscribe for reads. Especially if the
splicing is enabled (or if we are waiting the input buffer is flushed). Because
in that case, waking up the H1 connection leads to a ping-pong loop with
h1_recv() function. Indeed, in h1_recv(), if the splicing is enabled, no receive
is performed and the H1 stream is woken up.

This bug is specific to the 2.1. Thus, there is no upstream commit ID for this
patch. But in the 2.2, it is part of the commit 2c1f37d35 ("OPTIM: mux-h1:
subscribe rather than waking up at a few other places"). The 2.0 must be
evaluated to know if this patch must be backported or not.

(cherry picked from commit a1dde23e936adb66f6eaba33fc5bf93278b8efbd)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>