CLEANUP: peers: Replace hard-coded values by macros.
All the peer stick-table messages are made of a 2-byte header (PEER_MSG_HEADER_LEN)
followed by the encoded length of the remaining data wich is harcoded as 5 (in bytes)
for the maximum (PEER_MSG_ENCODED_LENGTH_MAXLEN). With such a length we can encode
a maximum length which equals to (1 << 32) - 1, which is from far enough.
This patches replaces both these values by macros where applicable.
diff --git a/src/peers.c b/src/peers.c
index 2a9fde1..9733e1b 100644
--- a/src/peers.c
+++ b/src/peers.c
@@ -167,6 +167,11 @@
#define PEER_MSG_STKT_UPDATE_TIMED 0x85
#define PEER_MSG_STKT_INCUPDATE_TIMED 0x86
+/* The maximum length of an encoded data length. */
+#define PEER_MSG_ENC_LENGTH_MAXLEN 5
+
+#define PEER_MSG_HEADER_LEN 2
+
/**********************************/
/* Peer Session IO handler states */
/**********************************/
@@ -516,7 +521,7 @@
struct shared_table *st;
st = params->swtch.shared_table;
- cursor = datamsg = msg + 2 + 5;
+ cursor = datamsg = msg + PEER_MSG_HEADER_LEN + PEER_MSG_ENC_LENGTH_MAXLEN;
/* Encode data */
@@ -596,7 +601,7 @@
uint32_t netinteger;
struct shared_table *st;
- cursor = datamsg = msg + 2 + 5;
+ cursor = datamsg = msg + PEER_MSG_HEADER_LEN + PEER_MSG_ENC_LENGTH_MAXLEN;
st = p->ack.shared_table;
intencode(st->remote_id, &cursor);