BUG/MINOR: tcp-rules: completely free incorrect TCP rules on error
When a tcp-request or tcp-response rule fails to parse, we currently
free only the rule without its contents, which makes ASAN complain.
Now that we have a new function for this, let's completely free the
rule. Reg-tests are now completely OK with ASAN. This relies on this
commit:
MINOR: actions: add new function free_act_rule() to free a single rule
It's probably not needed to backport this since we're on the exit path
anyway.
diff --git a/src/tcp_rules.c b/src/tcp_rules.c
index 82c1c59..e4c7647 100644
--- a/src/tcp_rules.c
+++ b/src/tcp_rules.c
@@ -1192,7 +1192,7 @@
return warn;
error:
- free(rule);
+ free_act_rule(rule);
return -1;
}
@@ -1406,7 +1406,7 @@
return warn;
error:
- free(rule);
+ free_act_rule(rule);
return -1;
}