tree 24fefee0220508198857a5ee0820b867cd033566
parent fddb96b2ec9b336dcd40ee5c2340aa7fcee3c966
author Willy Tarreau <w@1wt.eu> 1654852304 +0200
committer Christopher Faulet <cfaulet@haproxy.com> 1658416435 +0200

BUG/MINOR: server: do not enable DNS resolution on disabled proxies

Leonhard Wimmer reported an interesting bug in github issue #1742.
Servers in disabled proxies that are configured for resolution are still
subscribed to DNS resolutions, but the LB algos are not initialized at
all since the proxy is disabled, so when the server state changes,
attempts to update its status cause a crash when the server's weight
is recalculated via a divide by the proxy's total weight which is zero.

This should be backported to all versions. Beware that before 2.5 or
so, there's no PR_FL_DISABLED flag, instead px->disabled should be
used (2.3-2.4) or PR_STSTOPPED for older versions.

Thanks to Leonhard for his report and quick test!

(cherry picked from commit 9b46fb4cca9ab673be8d1cdce6876a4abaa7918e)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 488a561c85cabb3b21f581e5ec1585af0f751b35)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 3cda5bc784f4e80632a8953fc1342e1555dc3a71)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>