tree aff8888368647f8820fbae0d8bc0c1d193ed1abd
parent dc6e8a9a7b19052b8fd8ab7f9a84a4a95b4a6d5b
author Willy Tarreau <w@1wt.eu> 1594874427 +0200
committer Willy Tarreau <w@1wt.eu> 1594874644 +0200
encoding latin1

BUG/MEDIUM: server: fix possibly uninitialized state file on close

Previous fix dc6e8a9a7 ("BUG/MEDIUM: server: resolve state file handle
leak on reload") traded a bug for another one, now we get this warning
when building server.c, which is valid since f is not necessarily
initialized (e.g. if no global state file is passed):

  src/server.c: In function 'apply_server_state':
  src/server.c:3272:3: warning: 'f' may be used uninitialized in this function [-Wmaybe-uninitialized]
     fclose(f);
   ^~~~~~~~~

Let's initialize it first. This whole code block should really be
splitted, cleaned up and reorganized as it's possible that other
similar bugs are hidden in it.

This must be backported to the same branches the commit above is
backported to (likely 2.2 and 2.1).