CLEANUP: lists/tree-wide: rename some list operations to avoid some confusion
The current "ADD" vs "ADDQ" is confusing because when thinking in terms
of appending at the end of a list, "ADD" naturally comes to mind, but
here it does the opposite, it inserts. Several times already it's been
incorrectly used where ADDQ was expected, the latest of which was a
fortunate accident explained in 6fa922562 ("CLEANUP: stream: explain
why we queue the stream at the head of the server list").
Let's use more explicit (but slightly longer) names now:
LIST_ADD -> LIST_INSERT
LIST_ADDQ -> LIST_APPEND
LIST_ADDED -> LIST_INLIST
LIST_DEL -> LIST_DELETE
The same is true for MT_LISTs, including their "TRY" variant.
LIST_DEL_INIT keeps its short name to encourage to use it instead of the
lazier LIST_DELETE which is often less safe.
The change is large (~674 non-comment entries) but is mechanical enough
to remain safe. No permutation was performed, so any out-of-tree code
can easily map older names to new ones.
The list doc was updated.
diff --git a/src/vars.c b/src/vars.c
index 980b669..03aade2 100644
--- a/src/vars.c
+++ b/src/vars.c
@@ -150,7 +150,7 @@
ha_free(&var->data.u.meth.str.area);
size += var->data.u.meth.str.data;
}
- LIST_DEL(&var->l);
+ LIST_DELETE(&var->l);
pool_free(var_pool, var);
size += sizeof(struct var);
return size;
@@ -373,7 +373,7 @@
var = pool_alloc(var_pool);
if (!var)
return 0;
- LIST_ADDQ(&vars->head, &var->l);
+ LIST_APPEND(&vars->head, &var->l);
var->name = name;
}