CLEANUP: lists/tree-wide: rename some list operations to avoid some confusion
The current "ADD" vs "ADDQ" is confusing because when thinking in terms
of appending at the end of a list, "ADD" naturally comes to mind, but
here it does the opposite, it inserts. Several times already it's been
incorrectly used where ADDQ was expected, the latest of which was a
fortunate accident explained in 6fa922562 ("CLEANUP: stream: explain
why we queue the stream at the head of the server list").
Let's use more explicit (but slightly longer) names now:
LIST_ADD -> LIST_INSERT
LIST_ADDQ -> LIST_APPEND
LIST_ADDED -> LIST_INLIST
LIST_DEL -> LIST_DELETE
The same is true for MT_LISTs, including their "TRY" variant.
LIST_DEL_INIT keeps its short name to encourage to use it instead of the
lazier LIST_DELETE which is often less safe.
The change is large (~674 non-comment entries) but is mechanical enough
to remain safe. No permutation was performed, so any out-of-tree code
can easily map older names to new ones.
The list doc was updated.
diff --git a/addons/wurfl/wurfl.c b/addons/wurfl/wurfl.c
index 8ec1783..e9780e4 100644
--- a/addons/wurfl/wurfl.c
+++ b/addons/wurfl/wurfl.c
@@ -204,7 +204,7 @@
wi->data.name = strdup(args[argIdx]);
wi->data.type = HA_WURFL_DATA_TYPE_UNKNOWN;
wi->data.func_callback = NULL;
- LIST_ADDQ(&global_wurfl.information_list, &wi->list);
+ LIST_APPEND(&global_wurfl.information_list, &wi->list);
++argIdx;
}
@@ -232,7 +232,7 @@
}
wp->patch_file_path = strdup(args[argIdx]);
- LIST_ADDQ(&global_wurfl.patch_file_list, &wp->list);
+ LIST_APPEND(&global_wurfl.patch_file_list, &wp->list);
++argIdx;
}
@@ -410,12 +410,12 @@
ha_free(&global_wurfl.cache_size);
list_for_each_entry_safe(wi, wi2, &global_wurfl.information_list, list) {
- LIST_DEL(&wi->list);
+ LIST_DELETE(&wi->list);
free(wi);
}
list_for_each_entry_safe(wp, wp2, &global_wurfl.patch_file_list, list) {
- LIST_DEL(&wp->list);
+ LIST_DELETE(&wp->list);
free(wp);
}