tree 943299a09baa2cd52731f4a34a84dfc405875746
parent 20a18342195c36b60e4c36227034383411d9382f
author Willy Tarreau <w@1wt.eu> 1386152225 +0100
committer Willy Tarreau <w@1wt.eu> 1386206628 +0100
encoding latin1

MEDIUM: checks: centralize error reporting

Error reporting in health checks is unreliable as the number of recent
patch shows. The main reason is that the code required to detect the
exact situation where the error occurred is not simple, and the errors
have to be handled closer to where they occur in order to be accurate
(rely on getsockopt(SO_ERROR) and errno).

To solve this, we introduce chk_report_conn_err(). It does its best to
consider a possible errno passed in argument, a possible timeout passed
as well, then it completes this with getsockopt() if needed, and takes
into account the current status of the connection. The result is that
by simply calling this function with errno when it's known, we can emit
accurate log messages from every location. We can now see a messages
like "Connection error during SSL handshake (No route to host)" which
were not previously possible.