MEDIUM: proxy: remove long-broken 'option http_proxy'
This option had always been broken in HTX, which means that the first
breakage appeared in 1.9, that it was broken by default in 2.0 and that
no workaround existed starting with 2.1. The way this option works is
praticularly unfit to the rest of the configuration and to the internal
architecture. It had some uses when it was introduced 14 years ago but
nowadays it's possible to do much better and more reliable using a
set of "http-request set-dst" and "http-request set-uri" rules, which
additionally are compatible with DNS resolution (via do-resolve) and
are not exclusive to normal load balancing. The "option-http_proxy"
example config file was updated to reflect this.
The option is still parsed so that an error message gives hints about
what to look for.
diff --git a/src/cfgparse.c b/src/cfgparse.c
index fed8f7e..3ac31fc 100644
--- a/src/cfgparse.c
+++ b/src/cfgparse.c
@@ -2579,7 +2579,7 @@
err_code |= ERR_WARN;
}
}
- else if (!(curproxy->options & (PR_O_TRANSP | PR_O_DISPATCH | PR_O_HTTP_PROXY))) {
+ else if (!(curproxy->options & (PR_O_TRANSP | PR_O_DISPATCH))) {
/* If no LB algo is set in a backend, and we're not in
* transparent mode, dispatch mode nor proxy mode, we
* want to use balance roundrobin by default.
@@ -2590,11 +2590,9 @@
}
if (curproxy->options & PR_O_DISPATCH)
- curproxy->options &= ~(PR_O_TRANSP | PR_O_HTTP_PROXY);
- else if (curproxy->options & PR_O_HTTP_PROXY)
- curproxy->options &= ~(PR_O_DISPATCH | PR_O_TRANSP);
+ curproxy->options &= ~PR_O_TRANSP;
else if (curproxy->options & PR_O_TRANSP)
- curproxy->options &= ~(PR_O_DISPATCH | PR_O_HTTP_PROXY);
+ curproxy->options &= ~PR_O_DISPATCH;
if ((curproxy->tcpcheck_rules.flags & TCPCHK_RULES_UNUSED_HTTP_RS)) {
ha_warning("%s '%s' uses http-check rules without 'option httpchk', so the rules are ignored.\n",